Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chill.ClosureCleaner to remove outer$ refs on Functions #273

Closed
wants to merge 1 commit into from

Conversation

johnynek
Copy link
Collaborator

@johnynek
Copy link
Collaborator Author

Looks like there are serialization errors going on here with this change. Need to look more carefully at what is going on. Candidates: maybe ClosureCleaner needs to be Serializable. Maybe there is some breakage with the ClosureCleaner itself. Maybe chill is having problem serializing some resulting data.

@johnynek
Copy link
Collaborator Author

Actually, it looks like ClosureCleaner is either a no-op or busted now, so let's hold off here. Watch this issue:

twitter/chill#21

Once this is good, we can reconsider.

@johnynek
Copy link
Collaborator Author

I am starting to think this closure cleaner thing is only useful for a repl.

Closing until we get someone working on that or we prove otherwise.

@johnynek johnynek closed this Jul 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant